Add pull-up resistor control #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey Glen, |
Author
|
I was thinking the same thing but just fixed what I need in the short term. I can do the rest if you like.
Glenn
Glenn L. Hickman Jr.
WHRO
5200 Hampton Boulevard | Norfolk, VA 23508
P: 757.575.5064<tel:757.575.5064> | F: 757.489.0007<tel:757.489.0007>
glennh@whro.org<mailto:glennh@whro.org>
whro.org<http://whro.org>
…-------- Original message --------
From: telliottosceola <notifications@github.com>
Date: 8/7/17 09:56 (GMT-05:00)
To: ControlEverythingCom/NCD2Relay <NCD2Relay@noreply.github.com>
Cc: Glenn Hickman <Glenn.Hickman@whro.org>, Author <author@noreply.github.com>
Subject: Re: [ControlEverythingCom/NCD2Relay] Add pull-up resistor control (#3)
Hey Glen,
Thanks for the pull request. I am thinking a whole initialization function should be added to the library(replacing the setAddress function). The function would allow the user to set the I2C address of the chip, the IO direction of the 6 spare IOs on the 2 relay boards and also pull inputs high or let them float. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGmbkFJ5zyqGioudDBb1FCUOqi6GRKhUks5sVxeMgaJpZM4Or1I9>.
|
Author
|
Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff? |
Member
|
Hi Glen,
Yes, that could certainly be done as well. I just worry about setAddress setting those pull ups and IO directions, it really has to be called first, and then setIODirection and setPullUps
Travis Elliott
National Control Devices
430 Market St
Osceola Mo 64776
417 646 5644
travis@controlanything.com
… On Aug 7, 2017, at 9:50 AM, Glenn Hickman ***@***.***> wrote:
Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHSCEDVWn2hQ4XYs1bSj9EsrBNTA1Nwkks5sVyQ2gaJpZM4Or1I9>.
|
Author
|
I'll code it up and send it on for your approval.
Glenn L. Hickman Jr.
WHRO
5200 Hampton Boulevard | Norfolk, VA 23508
P: 757.575.5064<tel:757.575.5064> | F: 757.489.0007<tel:757.489.0007>
glennh@whro.org<mailto:glennh@whro.org>
whro.org<http://whro.org>
-------- Original message --------
From: telliottosceola <notifications@github.com>
Date: 8/7/17 14:13 (GMT-05:00)
To: ControlEverythingCom/NCD2Relay <NCD2Relay@noreply.github.com>
Cc: Glenn Hickman <Glenn.Hickman@whro.org>, Author <author@noreply.github.com>
Subject: Re: [ControlEverythingCom/NCD2Relay] Add pull-up resistor control (#3)
Hi Glen,
Yes, that could certainly be done as well. I just worry about setAddress setting those pull ups and IO directions, it really has to be called first, and then setIODirection and setPullUps
Travis Elliott
National Control Devices
430 Market St
Osceola Mo 64776
417 646 5644
travis@controlanything.com
On Aug 7, 2017, at 9:50 AM, Glenn Hickman ***@***.***> wrote:
Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHSCEDVWn2hQ4XYs1bSj9EsrBNTA1Nwkks5sVyQ2gaJpZM4Or1I9>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGmbkEAyUcr2lARCYruHAyPvR6KvUsvpks5sV1PCgaJpZM4Or1I9>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this functionality to the official firmware will expose the input pin pull-up resistor control to all users. It will make my life a lot easier too.
I'll be more than happy to do this for the other relay controllers as well.
Thanks for taking a look, Glenn.